fix(#1238): bun adapter add qi to routes that need query from guard #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d but not in handler
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1238
src/adapter/bun/compose.tsdidn't account for routes that have a guard that requires query, thus leading to a bug. This PR adds a straightforward check for it, bypassingsucrosecallsWhile this works, I think(?) that it would be better to handle route validators (including standalone validators) inside
sucroseif I understand the purpose of this function right, but as of now I can't think of a way to do it properlyWould love to hear SaltyAoms thought on it. Also there is a test included for this specific case